Simplify stride calculations in loglocator. #12866
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just algebraic manipulations:
In classic mode, we want the smallest stride so that
i.e.
so stride is the ceil() of the RHS (and at least 1, to handle the case
vmin==vmax).
In nonclassic mode, we want the smallest stride so that
(everything is integer), i.e.
i.e.
so stride is 1 + the floor() of the LHS.
PR Summary
PR Checklist